[FLINK-38262][table] show create connection operation - #28791
Open
Shekharrajak wants to merge 3 commits into
Open
[FLINK-38262][table] show create connection operation#28791Shekharrajak wants to merge 3 commits into
Shekharrajak wants to merge 3 commits into
Conversation
Collaborator
Generated-by: Codex (GPT-5)
Shekharrajak
force-pushed
the
FLINK-38262-show-create-connection-operation
branch
from
July 21, 2026 17:16
1683711 to
0b21c6e
Compare
snuyanzin
requested changes
Jul 21, 2026
snuyanzin
left a comment
snuyanzin
left a comment
Contributor
There was a problem hiding this comment.
Please do not ignore Contributors form
raminqaf
reviewed
Jul 27, 2026
Comment on lines
+377
to
+387
| static Optional<String> extractComment(CatalogConnection connection) { | ||
| return StringUtils.isEmpty(connection.getComment()) | ||
| ? Optional.empty() | ||
| : Optional.of(connection.getComment()); | ||
| } | ||
|
|
||
| static Map<String, String> withoutConnectionInternalOptions(Map<String, String> options) { | ||
| return options.entrySet().stream() | ||
| .filter(entry -> !CONNECTION_SECRET_REFERENCE_KEY.equals(entry.getKey())) | ||
| .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue)); | ||
| } |
raminqaf
reviewed
Jul 27, 2026
| private static final DateTimeFormatter TIMESTAMP_FORMATTER = | ||
| DateTimeFormatter.ofPattern("uuuu-MM-dd HH:mm:ss"); | ||
| private static final String PRINT_INDENT = " "; | ||
| private static final String CONNECTION_SECRET_REFERENCE_KEY = "__flink.encrypted-secret-key__"; |
Contributor
There was a problem hiding this comment.
Can you elaborate what this const is? Maybe add a one line comment why we filtering it out.
raminqaf
reviewed
Jul 27, 2026
raminqaf
reviewed
Jul 27, 2026
raminqaf
left a comment
raminqaf
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution. Left some comments
github-actions
Bot
added
the
community-reviewed
…k/table/catalog/CatalogManager.java Co-authored-by: Ramin Gharib <ramingharib@gmail.com>
…k/table/catalog/CatalogManager.java Co-authored-by: Ramin Gharib <ramingharib@gmail.com>
snuyanzin
requested changes
Jul 27, 2026
snuyanzin
left a comment
snuyanzin
left a comment
Contributor
There was a problem hiding this comment.
if you change ShowCreateUtil then there should be tests in ShowCreateUtilTests with pure sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Adds resolved connection lookup and SHOW CREATE CONNECTION support, formatting connection DDL while filtering internal/sensitive options.
Brief change log
Add SHOW CREATE CONNECTION operation
Verifying this change
Unit tests and IT
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no) noDocumentation
Was generative AI tooling used to co-author this PR?